Fix network modules for ziploader changes #15311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
ziploader (#15246) changed the behavior of _load_params such that it does not return the parameter dictionary, but rather sets it directly. This fixes the network modules so that they use this preset dictionary rather than the output of
super(...)._load_params()
(as there is now no output).Additionally, some modules check for task-set parameters first, and others do not. This change standardizes this behavior to prefer task-set parameters.